enableRoslynAnalyzers flag.

[savpek]

Requires OmniSharp/omnisharp-roslyn#1076 from omnisharp-roslyn to function.

Adds flag:

"omnisharp.enableRoslynAnalyzers": true

That can enable feature without modifying omnisharp.json when used with vscode.

[dnfclas]

All CLA requirements met.

[codecov]

Codecov Report

Merging #2836 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
+ Coverage   89.87%   89.89%   +0.01%     
==========================================
  Files          59       59              
  Lines        1581     1583       +2     
  Branches       89       89              
==========================================
+ Hits         1421     1423       +2     
  Misses        149      149              
  Partials       11       11

Flag	Coverage Δ
#integration	100% <ø> (ø)	⬆️
#unit	89.89% <100%> (+0.01%)	⬆️

Impacted Files	Coverage Δ
src/omnisharp/options.ts	95.08% <100%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1279c53...2672b86. Read the comment docs.

[akshita31]

Thanks !

[savpek]

I will merge this once analyzers are available on omnisharp-roslyn master branch.

[akshita31]

@savpek Any updates here ?

[savpek]

@akshita31 waiting for review/approval to omnisharp-roslyn side of analyzers from @rchande and @david-driscoll

[savpek]

@akshita31 @rchande this probably can be merged since OmniSharp/omnisharp-roslyn#1076 is available in master branch.

[akshita31]

It would be better to merge this when we include a new version of omnisharp in the extension.