Improve logging for 'dotnet --info' failures (#159) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuckries and @DustinCampbell please review when you have extra cycles, but no rush as this isn't for RC2. |
Previously failures from dotnet --info generated no logging. This adds code to output what is happening.
gregg-miskelly
force-pushed
the
FixDotnetInfoLogging
branch
from
0442439
to
01aa7b6
Compare
|
👍 |
|
@DustinCampbell do you want to review this, or should I just complete it (no rush on actually reviewing this if you are heads down on RC2 work)? |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously failures from dotnet --info generated no logging. This adds code to output what is happening.