Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug install fails with no diagnostics if 'dotnet --info' doesn't return the RID #159

Closed
gregg-miskelly opened this issue Apr 7, 2016 · 3 comments

Comments

@gregg-miskelly
Copy link
Contributor

Repro steps:

  1. Install older build of .NET CLI (build 2202 seems to cause this, probably others would too)
  2. Install VS Code+C# extension
  3. Try to restore debugger

Result:
Error saying "Error while installing .NET Core Debugger" whenever I open VS Code with the extension installed. When I hit the "View Log" button next to it, nothing happens (no log opens).

Notes:
On the following line, we will throw an error if the dotnet --info doesn't return the RID:
https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/coreclr-debug/util.ts#L137

But the error from the exception is dropped on the floor here:
https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/coreclr-debug/main.ts#L89

Suggested changes:

  1. Write the call and output from dotnet --info to the log
  2. Write the error message to the log
@gregg-miskelly
Copy link
Contributor Author

@MattGertz I know you were asking about upgrade testing. Do you care enough about this scenario that you would want to take the fix, or should we move this to RTM?

@MattGertz
Copy link

RTM, and we can educate in the interim.

@gregg-miskelly gregg-miskelly added this to the 1.0.0-rtm milestone Apr 8, 2016
gregg-miskelly added a commit to gregg-miskelly/vscode-csharp that referenced this issue Apr 8, 2016
Previously failures from dotnet --info generated no logging. This adds code to output what is happening.
gregg-miskelly added a commit to gregg-miskelly/vscode-csharp that referenced this issue Apr 8, 2016
Previously failures from dotnet --info generated no logging. This adds code to output what is happening.
gregg-miskelly added a commit that referenced this issue Apr 13, 2016
Improve logging for 'dotnet --info' failures (#159)
@gregg-miskelly
Copy link
Contributor Author

Fixed for post-RC2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants