Skip to content

Conversation

@vlada-shubina
Copy link
Member

Problem

No translation for templates in the repo

Solution

Added English translation files for templates
Fixed issue in Template Localizer tool avoiding to generate templatestrings.json for the first time

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

Copy link
Contributor

@jonfortescue jonfortescue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bekir-ozturk bekir-ozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests. Nice!

@vlada-shubina vlada-shubina merged commit 0a06e8e into dotnet:main Jun 18, 2021
@vlada-shubina vlada-shubina deleted the fix-templatestrings.json branch June 18, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants