Skip to content

Conversation

@dotnet-bot
Copy link
Contributor

No description provided.

@dotnet-bot dotnet-bot requested a review from a team as a code owner June 17, 2021 17:15
@vlada-shubina
Copy link
Member

@jonfortescue this build seems to be correct, but some test are failing - I'll take a look.
One question: why does it touches all the templates for translation but generates no content? Can we easily insert tool run to get content?

@jonfortescue
Copy link
Contributor

Fantastic to see that it's working now!

As for why it's touching those templates -- it's (annoyingly) switching the Unicode BOM at the beginning of the file. very obnoxious and noisy. I've asked the loc team to fix it.

Why it's generating no content -- I believe those are empty test templates. The real templates won't be touched until I push through an arcade feature to include them (which I am working on doing!).

@@ -0,0 +1 @@
{} No newline at end of file
Copy link
Member

@vlada-shubina vlada-shubina Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonfortescue I didn't spot it from the beginning, but in fact this PR doubles all json files and with invalid names.
image
I think we should we fix it first before we merge the PR.

Which file do you expect to be stored in the repo?

  • templatestrings.json
  • templatestrings.en.json
  • templatestrings.[all 16 lang codes].json

I can fix it tomorrow and remove the wrong files: now they are named in wrong order in the repo: en.templatestrings.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely remove these files before merging! agreed agreed. this will be fixed on the next arcade update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3307 fixes templatestrings.json names and adds strings to be translated. Hopefully after that one is in, the generated files will be correct.

@vlada-shubina vlada-shubina deleted the locfiles/1ad02a7a-cde2-48ff-9250-ffd07a652f75 branch July 22, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants