Update HTTPS server variable in ProxyHeaderModule #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
tasou/update-https-server
branch
from
d78c437 to
bc9cee0
Compare
twsouthwick
force-pushed
the
tasou/update-https-server
branch
from
bc9cee0 to
9c2e599
Compare
We were updating SERVER_PROTOCOL which is not used in IIS for HTTP/HTTPS, but rather the version of HTTP. Instead, we need to update the HTTPS server variable.
twsouthwick
force-pushed
the
tasou/update-https-server
branch
from
9c2e599 to
f4cc42b
Compare
Tratcher
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were updating
SERVER_PROTOCOLwhich is not used in IIS for HTTP/HTTPS, but rather the version of HTTP. Instead, we need to update the HTTPS server variable.Fixes #118