X-Forwarded-Proto isn't respected in MVC Request due to wrong server variable being set

[DorianGreen]

Describe the bug

ProxyHeaderModule is currently setting the SERVER_PROTOCOL variable based on x-forwarded-proto.
This variable is should be used to denote the HTTP protocol (i.e. HTTP/1.1 or HTTP2) and not the scheme (HTTP vs HTTPS).
IIS/ASP.NET use the HTTPS boolean server variable for the scheme.

To Reproduce

1. send a request to any controller action with http scheme, adding a X-Forwarded-Proto=https header
2. in the action check context..Request.RequestUri.Scheme
3. value should be https but returns http

[twsouthwick]

@DorianGreen This has been fixed and will be available in preview 3. See #92

[DorianGreen]

The fix doesn't address the issue, it sets the correct port, but not the correct scheme.

SERVER_PROTOCOL is the wrong variable to set, and MVC webapi doesn't know how to handle it.

SERVER_PROTOCOL should be used for HTTP1.1 vs HTTP2 and not for HTTP vs HTTPS.

the correct server variable to set is HTTPS with a value of ON for HTTPS and OFF for HTTP.

[twsouthwick]

OK. I'll reopen and look into this.