Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo level prebuilt baseline should not require an exclusion for intermediate packages #3010

Closed
MichaelSimons opened this issue Aug 26, 2022 · 3 comments
Assignees
Labels
area-arcade Common Arcade source-build infra

Comments

@MichaelSimons
Copy link
Member

Right now if you utilize the repo level prebuilt baseline infrastructure from arcade, you will have to add exclusions for the source-build intermediate packages.

Example from source-build-reference-packages - https://github.com/dotnet/source-build-reference-packages/blob/main/eng/SourceBuildPrebuiltBaseline.xml#L7

<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" />

Given these are common prebuilts they should be included as part of the infrastructure rather than requiring each repo to add these exclusions.

@MichaelSimons MichaelSimons added the area-arcade Common Arcade source-build infra label Aug 26, 2022
@MichaelSimons MichaelSimons moved this to 8.0 Backlog in .NET Source Build Aug 26, 2022
@tkapin tkapin self-assigned this Sep 8, 2022
@tkapin
Copy link
Member

tkapin commented Sep 8, 2022

As agreed with @MichaelSimons, I'll take this one as part of the hackathon to get some hands-on experience with source-build. Assigning to myself.

@MichaelSimons MichaelSimons moved this to 8.0 On Deck in .NET Source Build Sep 12, 2022
@MichaelSimons MichaelSimons moved this from 8.0 On Deck to 8.0 Backlog in .NET Source Build Dec 12, 2022
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 8.0 Preview 6 in .NET Source Build Jun 1, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Preview 6 to 8.0 Backlog in .NET Source Build Jun 15, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 9.0 Lull in .NET Source Build Jul 20, 2023
@MichaelSimons MichaelSimons moved this from Post 8.0 / Pre 9.0 to Preview 1 in .NET Source Build Nov 14, 2023
@ellahathaway ellahathaway moved this from Preview 1 to In Progress in .NET Source Build Nov 29, 2023
@ellahathaway
Copy link
Member

Right now if you utilize the repo level prebuilt baseline infrastructure from arcade, you will have to add exclusions for the source-build intermediate packages.

This was resolved by dotnet/arcade@769f8b1. Only work to do is to remove all the exclusions from the baselines for the repos listed in dotnet/arcade#14256

This was referenced Dec 8, 2023
mikem8361 pushed a commit to dotnet/diagnostics that referenced this issue Dec 9, 2023
Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates
as prebuilts due to dotnet/arcade#13935.

Addresses dotnet/source-build#3010
rainersigwald pushed a commit to dotnet/msbuild that referenced this issue Dec 12, 2023
Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates as prebuilts due to dotnet/arcade#13935.

Addresses dotnet/source-build#3010
@ellahathaway
Copy link
Member

Closing this issue since PRs from all relevant repos have been merged.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-arcade Common Arcade source-build infra
Projects
Archived in project
Development

No branches or pull requests

4 participants