Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.SourceBuild.Intermediate from prebuilt baseline #95798

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

ellahathaway
Copy link
Member

Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates as prebuilts due to dotnet/arcade#13935.

Addresses dotnet/source-build#3010

@ghost
Copy link

ghost commented Dec 8, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates as prebuilts due to dotnet/arcade#13935.

Addresses dotnet/source-build#3010

Author: ellahathaway
Assignees: ellahathaway
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Resolves issue dotnet/source-build#3010 for runtime, and the change is consistent with the other PRs from other repos linked in dotnet/source-build#3010 and in dotnet/arcade#13935 .

@ellahathaway ellahathaway merged commit 9ac84d7 into dotnet:main Dec 8, 2023
176 of 180 checks passed
@ellahathaway ellahathaway deleted the update-prebuilt-baseline branch December 8, 2023 23:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants