Skip to content

Conversation

@mthalman
Copy link
Member

Adds Microsoft.Extensions.ObjectPool 6.0.0 due to prebuilt being introduced for this package from https://github.com/dotnet/razor. This looks to have been caused by dotnet/razor#8289.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, From https://github.com/dotnet/source-build-reference-packages#reference

After generating new reference packages, all new projects must be referenced as a DependencyPackageProjects. These must be defined in dependency order.

@mthalman
Copy link
Member Author

FYI, From https://github.com/dotnet/source-build-reference-packages#reference

After generating new reference packages, all new projects must be referenced as a DependencyPackageProjects. These must be defined in dependency order.

This is what confuses me. Why is only one listed when there are a whole bunch of other packages in src?

@MichaelSimons
Copy link
Member

FYI, From https://github.com/dotnet/source-build-reference-packages#reference

After generating new reference packages, all new projects must be referenced as a DependencyPackageProjects. These must be defined in dependency order.

Only new projects are added here until the previous source-build-artifacts get updated in which they are removed. See for details: https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L11. This all related to the problem of project references not being utilized in the projects.

@MichaelSimons MichaelSimons merged commit 9958e1d into dotnet:main Feb 27, 2023
@mthalman mthalman deleted the objectpool branch March 8, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants