Update SourceGenerator.Tooling.Internal with Utilities.Shared #8289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I believe this will conflict with the changes in #8245, where I added the shared lib as a project reference to MS.AspNet.Language |
Member
Author
I wasn't sure if a project reference was legit, since there was such care taken to link everything. If your change is the correct one, I'm happy to take that over this. |
Member
Author
|
@dotnet/razor-compiler: I've enabled auto-merge. Feel free to add a green checkmark to let this go in before #8245. |
Member
|
I've disabled auto-merge, as we require 2 reviews for compiler changes. Sorry 🙂. |
333fred
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change links all of the files from
Microsoft.AspNetCore.Razor.Utilities.SharedintoMicrosoft.AspNetCore.Razor.SourceGenerator.Tooling.Internal, now thatUtilities.Sharedis referenced byMicrosoft.AspNetCore.Razor.Language. Otherwise,SourceGenerators.Tooling.Internalwill fail to build if anything fromUtilities.Sharedis actually used.@333fred: I noticed that
Microsoft.AspNetCore.Razor.SourceGenerator.Tooling.Internaldoes not directly referenceSystem.Collections.Immutable, so it's transitively referencing it through its reference toMicrosoft.CodeAnalysis.CSharp. Would it make sense to add a direct reference inSourceGenerator.Tooling.Internalto ensure that it builds with the same version asMicrosoft.AspNetCore.Razor.Language?