Skip to content

Load only skill that is pointed by test #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JanKrivanek wants to merge 1 commit into from
Closed

Load only skill that is pointed by test #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/skill-validator/src/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export function buildSessionConfig(
model: string,
workDir: string
): SessionConfig {
const skillPath = skill ? dirname(skill.path) : undefined;
const skillPath = skill ? skill.path : undefined;
return {
model,
streaming: true,
Expand Down
4 changes: 2 additions & 2 deletions eng/skill-validator/tests/runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ describe("buildSessionConfig", () => {
evalConfig: null,
};

it("sets skillDirectories to parent of skill path", () => {
it("sets skillDirectories to the skill path itself", () => {
const config = buildSessionConfig(mockSkill, "gpt-4.1", "/tmp/work");
expect(config.skillDirectories).toEqual(["/home/user/skills"]);
expect(config.skillDirectories).toEqual(["/home/user/skills/test-skill"]);
});

it("sets workingDirectory to the workDir", () => {
Expand Down
Loading