Load only skill that is pointed by test - #87
Closed
JanKrivanek wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the skill-validator runner configuration so that when a test targets a specific skill, only that skill is loaded (avoiding cross-skill interactions from loading sibling skills).
Changes:
- Adjust
buildSessionConfigto setskillDirectoriesto the skill directory itself (instead of the parent directory). - Update the corresponding unit test expectation and description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/skill-validator/src/runner.ts | Changes session config to load only the targeted skill directory. |
| eng/skill-validator/tests/runner.test.ts | Updates test to assert skillDirectories points to the skill directory, not its parent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ViktorHofer
reviewed
Feb 23, 2026
ViktorHofer
left a comment
ViktorHofer
left a comment
Member
There was a problem hiding this comment.
This could be intentional. Not sure. @adityamandaleeka?
moesac0970
pushed a commit
to moesac0970/skills
that referenced
this pull request
Jul 4, 2026
…, no MSTest usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Running test for a specific skill loaded all the skills from under parent folder - so there could be unwanted interactions