Skip to content

Remove workarounds for a fixed issue in run-file tests #53214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 1 commit into from
Mar 3, 2026
Merged

Remove workarounds for a fixed issue in run-file tests #53214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions test/dotnet.Tests/CommandTests/Run/RunFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,19 +2135,11 @@ public void Build_Library_MultiTarget()
#:property OutputType=Library
#:property PublishAot=false
#:property LangVersion=preview
#:property TargetFramework=
#:property TargetFrameworks=netstandard2.0;{ToolsetInfo.CurrentTargetFramework}
class C;
""");

// https://github.com/dotnet/sdk/issues/51077: cannot set this via `#:property` directive.
File.WriteAllText(Path.Join(testInstance.Path, "Directory.Build.props"), """
<Project>
<PropertyGroup>
<TargetFramework></TargetFramework>
</PropertyGroup>
</Project>
""");

var artifactsDir = VirtualProjectBuilder.GetArtifactsPath(programFile);
if (Directory.Exists(artifactsDir)) Directory.Delete(artifactsDir, recursive: true);

Expand Down Expand Up @@ -2260,19 +2252,11 @@ public void Build_Exe_MultiTarget()
#:property OutputType=Exe
#:property PublishAot=false
#:property LangVersion=preview
#:property TargetFramework=
#:property TargetFrameworks=netstandard2.0;{ToolsetInfo.CurrentTargetFramework}
Console.WriteLine("Hello Exe");
""");

// https://github.com/dotnet/sdk/issues/51077: cannot set this via `#:property` directive.
File.WriteAllText(Path.Join(testInstance.Path, "Directory.Build.props"), """
<Project>
<PropertyGroup>
<TargetFramework></TargetFramework>
</PropertyGroup>
</Project>
""");

var artifactsDir = VirtualProjectBuilder.GetArtifactsPath(programFile);
if (Directory.Exists(artifactsDir)) Directory.Delete(artifactsDir, recursive: true);

Expand Down
Loading