Remove workarounds for a fixed issue in run-file tests#53214
Merged
jjonescz merged 1 commit intodotnet:release/10.0.3xxfrom Mar 3, 2026
Merged
Remove workarounds for a fixed issue in run-file tests#53214jjonescz merged 1 commit intodotnet:release/10.0.3xxfrom
jjonescz merged 1 commit intodotnet:release/10.0.3xxfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes workarounds from integration tests for issue #51077, which was about the inability to set TargetFramework to an empty value via the #:property directive in file-based programs. Now that the underlying issue is fixed, the tests can use #:property TargetFramework= directly instead of writing a Directory.Build.props file as a side-channel workaround.
Changes:
- Replaced the
Directory.Build.propsfile workaround inBuild_Library_MultiTargetwith a#:property TargetFramework=directive. - Replaced the same workaround in
Build_Exe_MultiTargetwith a#:property TargetFramework=directive.
3 tasks
MiYanni
approved these changes
Mar 3, 2026
Member
Author
|
(test only change, merging with one sign off) |
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #51077.