Use FrameworkList.xml instead of hard-coding references and analyzers in optimized CSC-only file-based app builds by Copilot · Pull Request #53205 · dotnet/sdk

Copilot · 2026-03-01T15:23:46Z

Add GetFrameworkReferenceArguments() method to CSharpCompilerCommand.cs
Update CSharpCompilerCommand.Generated.cs to replace 167 hard-coded /reference: lines with .. GetFrameworkReferenceArguments()
Update the test CscArguments in RunFileTests.cs to emit .. GetFrameworkReferenceArguments()
Address review: restore trailing newline in Microsoft.CodeAnalysis.NetAnalyzers.sarif
Address review: format spread with a space (.. GetFrameworkReferenceArguments())
Address review: remove redundant using System.Xml.Linq; (already a global using via Directory.Build.props)
Address review: add GetFrameworkAnalyzerArguments() and replace 6 hard-coded targeting-pack /analyzer: lines
Address review comment 2879241632: merge both methods into a shared GetFrameworkArguments(type, language, argPrefix) helper to eliminate code duplication
Verify the build succeeds and CscArguments test passes

Original prompt

This section details on the original issue you should resolve

<issue_title>Use FrameworkList.xml instead of hard-coding references in optimized CSC-only file-based app builds</issue_title>
<issue_description>See also #52727 (comment).
Related to #49528 (comment).</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Use FrameworkList.xml instead of hard-coding references in optimized CSC-only file-based app builds #52934

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

…le-based app builds Replace 167 hard-coded /reference: lines in CSharpCompilerCommand.Generated.cs with a dynamic GetFrameworkReferenceArguments() method that reads FrameworkList.xml from the current targeting pack at runtime. Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

jjonescz

@copilot

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.sarif

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.Generated.cs

…space in spread syntax Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot

Pull request overview

This PR removes hard-coded framework reference arguments from the optimized CSC-only dotnet run file.cs path by reading them dynamically from FrameworkList.xml, keeping the generated argument list in sync with the installed targeting pack.

Changes:

Add GetFrameworkReferenceArguments() to read framework references from packs/Microsoft.NETCore.App.Ref/<version>/data/FrameworkList.xml.
Replace ~167 hard-coded /reference: arguments in CSharpCompilerCommand.Generated.cs with a spread of GetFrameworkReferenceArguments().
Update RunFileTests.CscArguments generation + assertions to account for dynamic reference ordering and ensure references are present.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs	Updates generator + assertions to tolerate reference ordering differences and validate reference presence.
src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs	Adds FrameworkList.xml reader that yields `/reference:` arguments.
src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.Generated.cs	Replaces hard-coded framework reference list with `.. GetFrameworkReferenceArguments()`.

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.Generated.cs

…orkAnalyzerArguments Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

…ting-pack analyzers Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs

…to shared GetFrameworkArguments helper Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

test/dotnet.Tests/CommandTests/Run/RunFileTests.cs

jjonescz · 2026-03-05T17:22:08Z

@MiYanni for a review, thanks

Initial plan

13d9025

Copilot AI assigned Copilot and jjonescz Mar 1, 2026

Copilot started work on behalf of jjonescz March 1, 2026 15:23 View session

Copilot AI and others added 2 commits March 1, 2026 15:35

Initial plan

356fec5

Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update app builds to use FrameworkList.xml instead of hard-coded references~~ Use FrameworkList.xml instead of hard-coding references in optimized CSC-only file-based app builds Mar 1, 2026

Copilot finished work on behalf of jjonescz March 1, 2026 16:12

build-analysis bot mentioned this pull request Mar 1, 2026

dotnet-watch tests failing #40006

Open

jjonescz reviewed Mar 3, 2026

View reviewed changes

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.sarif Show resolved Hide resolved

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.Generated.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of jjonescz March 3, 2026 00:58 View session

Address review comments: restore trailing newline in sarif file, add …

5e34336

…space in spread syntax Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot finished work on behalf of jjonescz March 3, 2026 01:04

jjonescz approved these changes Mar 3, 2026

View reviewed changes

jjonescz added the Area-run-file Items related to the "dotnet run <file>" effort label Mar 3, 2026

jjonescz marked this pull request as ready for review March 3, 2026 01:11

jjonescz requested review from a team and Copilot March 3, 2026 01:11

Copilot started reviewing on behalf of jjonescz March 3, 2026 01:12 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs Outdated Show resolved Hide resolved

333fred approved these changes Mar 3, 2026

View reviewed changes

RikkiGibson approved these changes Mar 3, 2026

View reviewed changes

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs Outdated Show resolved Hide resolved

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.Generated.cs Show resolved Hide resolved

Copilot started work on behalf of jjonescz March 3, 2026 14:56 View session

Plan: address review comments - remove redundant using, add GetFramew…

60cc541

…orkAnalyzerArguments Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot AI requested a review from a team as a code owner March 3, 2026 15:05

Remove redundant using, add GetFrameworkAnalyzerArguments() for targe…

beea3df

…ting-pack analyzers Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot AI changed the title ~~Use FrameworkList.xml instead of hard-coding references in optimized CSC-only file-based app builds~~ Use FrameworkList.xml instead of hard-coding references and analyzers in optimized CSC-only file-based app builds Mar 3, 2026

Copilot finished work on behalf of jjonescz March 3, 2026 15:11

jjonescz reviewed Mar 3, 2026

View reviewed changes

src/Cli/dotnet/Commands/Run/CSharpCompilerCommand.cs Show resolved Hide resolved

Copilot started work on behalf of jjonescz March 3, 2026 16:22 View session

Merge GetFrameworkReferenceArguments/GetFrameworkAnalyzerArguments in…

c022ae0

…to shared GetFrameworkArguments helper Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>

Copilot finished work on behalf of jjonescz March 3, 2026 16:29

jjonescz requested review from MiYanni and RikkiGibson March 3, 2026 16:32

RikkiGibson approved these changes Mar 3, 2026

View reviewed changes

RikkiGibson reviewed Mar 3, 2026

View reviewed changes

test/dotnet.Tests/CommandTests/Run/RunFileTests.cs Show resolved Hide resolved

MiYanni approved these changes Mar 5, 2026

View reviewed changes

jjonescz mentioned this pull request Mar 5, 2026

[release/11.0.1xx-preview2] Source code updates from dotnet/dotnet #53267

Merged

jjonescz merged commit 94a9db1 into release/10.0.3xx Mar 5, 2026
28 checks passed

jjonescz deleted the copilot/use-frameworklist-xml branch March 5, 2026 22:23

This was referenced Mar 6, 2026

[release/10.0.3xx] Source code updates from dotnet/sdk dotnet/dotnet#5177

Closed

[main] Source code updates from dotnet/sdk dotnet/dotnet#5402

Merged

[release/10.0.3xx] Source code updates from dotnet/sdk dotnet/dotnet#5421

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use FrameworkList.xml instead of hard-coding references and analyzers in optimized CSC-only file-based app builds#53205

Use FrameworkList.xml instead of hard-coding references and analyzers in optimized CSC-only file-based app builds#53205
jjonescz merged 7 commits intorelease/10.0.3xxfrom
copilot/use-frameworklist-xml

Copilot AI commented Mar 1, 2026 •

edited

Loading

Uh oh!

jjonescz left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjonescz commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Copilot AI commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

jjonescz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjonescz commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Mar 1, 2026 •

edited

Loading