Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs style cleanup across multiple files in the BuiltInTools/Watch and HotReloadClient projects, focusing on code formatting, documentation fixes, and minor code improvements.
Changes:
- Removed UTF-8 BOM markers and extra blank lines from several source files
- Fixed XML documentation tags and removed trailing whitespace
- Simplified lambda expressions to method group references
- Added nullable type annotation to
OSSpecificPathComparer - Removed redundant field initializer and added readonly modifier
- Added Microsoft.Extensions.DependencyInjection.Abstractions package reference
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/BuiltInTools/Watch/Utilities/PathUtilities.cs | Changed IEqualityComparer<string> to IEqualityComparer<string?> for better nullability handling |
| src/BuiltInTools/Watch/Process/RunningProject.cs | Removed UTF-8 BOM and extra blank line |
| src/BuiltInTools/Watch/Process/ProcessSpec.cs | Removed extra blank line, redundant = false initialization, and fixed XML documentation tag |
| src/BuiltInTools/Watch/Process/ProcessRunner.cs | Removed UTF-8 BOM and extra blank line |
| src/BuiltInTools/Watch/Microsoft.DotNet.HotReload.Watch.csproj | Removed trailing whitespace from comment |
| src/BuiltInTools/Watch/HotReload/HotReloadEventSource.cs | Removed extra blank line |
| src/BuiltInTools/Watch/HotReload/HotReloadDotNetWatcher.cs | Removed BOM, simplified three lambda expressions to method group references |
| src/BuiltInTools/Watch/HotReload/CompilationHandler.cs | Removed BOM, removed outdated comment reference, simplified lambda to method group |
| src/BuiltInTools/Watch/FileWatcher/PollingDirectoryWatcher.cs | Added readonly modifier to _pollingThread field, simplified lambda to method group |
| src/BuiltInTools/Watch/FileWatcher/FileWatcher.cs | Simplified lambda expression to method group reference |
| src/BuiltInTools/Watch/Context/DotNetWatchContext.cs | Removed extra blank line |
| src/BuiltInTools/Watch/Build/ProjectNodeMap.cs | Removed UTF-8 BOM and extra blank line |
| src/BuiltInTools/Watch/Build/ProjectGraphFactory.cs | Removed BOM, fixed XML documentation tag from <see cref> to <paramref> |
| src/BuiltInTools/Watch/Build/FileItem.cs | Removed UTF-8 BOM and extra blank line |
| src/BuiltInTools/HotReloadClient/Microsoft.DotNet.HotReload.Client.Package.csproj | Added Microsoft.Extensions.DependencyInjection.Abstractions package reference |
src/BuiltInTools/HotReloadClient/Microsoft.DotNet.HotReload.Client.Package.csproj
Show resolved
Hide resolved
Member
Author
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
Changes look good. Can you explain why the Microsoft.Extensions.DependencyInjection.Abstractions dependency was added? I am not drawing a connection to style cleanup.
Member
Author
|
It's a dependency of |
MichaelSimons
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up diagnostics reported when building in Aspire repo: dotnet/aspire#14259