Skip to content

Watch fork for prototyping#14259

Merged
tmat merged 3 commits intodotnet:feature/watch-prototypefrom
tmat:InitialWatchImpl
Feb 5, 2026
Merged

Watch fork for prototyping#14259
tmat merged 3 commits intodotnet:feature/watch-prototypefrom
tmat:InitialWatchImpl

Conversation

@tmat
Copy link
Member

@tmat tmat commented Jan 30, 2026

No description provided.

@tmat tmat mentioned this pull request Jan 30, 2026
@karolz-ms
Copy link
Member

@eerhardt @radical would you please help @tmat get this PR in a state where it can be merged into the watch-prototype feature branch? I think the minumum goal is to make the prototype buildable manually/separately; it does not need to be automatically buildable with the rest of Aspire.

@eerhardt
Copy link
Member

looks like there are a bunch of misconfigured dependencies:

tests\Aspire.Hosting.Analyzers.Tests\Aspire.Hosting.Analyzers.Tests.csproj(0,0): error NU1701: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Package 'Microsoft.CodeAnalysis.CSharp.Workspaces 1.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.

src\Aspire.Hosting.Tasks\Aspire.Hosting.Tasks.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: System.Text.Json from 9.0.11 to centrally defined 8.0.6. Update the centrally managed package version to a higher version.
Aspire.Hosting.Tasks -> Microsoft.Build.Framework 18.3.0-preview-25610-02 -> System.Text.Json (>= 9.0.11)
Aspire.Hosting.Tasks -> System.Text.Json (>= 8.0.6)

src\Tools\ConfigurationSchemaGenerator\ConfigurationSchemaGenerator.csproj(0,0): error NU1010: (NETCORE_ENGINEERING_TELEMETRY=Restore) The following PackageReference items do not define a corresponding PackageVersion item: Microsoft.CodeAnalysis.CSharp.Workspaces. Projects using Central Package Management must declare PackageReference and PackageVersion items with matching names. For more information, visit https://aka.ms/nuget/cpm/gettingstarted

@tmat - do you know how to fix these? Or do you need someone to do it?

@tmat
Copy link
Member Author

tmat commented Jan 31, 2026

I'm not sure what versions of dependencies do you want to use. I'd prefer someone familiar with the requirements of the repo looked into these issues.

Microsoft.CodeAnalysis.CSharp.Workspaces 1.0.1

This is super old, why is it used?

Detected package downgrade: System.Text.Json from 9.0.11 to centrally defined 8.0.6

Is it ok to update to 9.0.11?

This means WatchPrototype dependencies won't affect the rest of the repo.
@eerhardt
Copy link
Member

eerhardt commented Feb 4, 2026

OK, I believe I've fixed the build errors related to dependency versions. .\build.cmd is green for me locally. Let me know if you need anything else from me.

@tmat tmat merged commit 6d34813 into dotnet:feature/watch-prototype Feb 5, 2026
6 checks passed
@tmat tmat deleted the InitialWatchImpl branch February 5, 2026 19:04
tmat added a commit to tmat/aspire that referenced this pull request Mar 5, 2026
* Watch fork for prototyping

* Single file programs

* Move WatchPrototype dependencies into their own Directory.Packages.props

This means WatchPrototype dependencies won't affect the rest of the repo.

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
tmat added a commit to tmat/aspire that referenced this pull request Mar 5, 2026
* Watch fork for prototyping

* Single file programs

* Move WatchPrototype dependencies into their own Directory.Packages.props

This means WatchPrototype dependencies won't affect the rest of the repo.

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants