Skip to content

Adjust MTP exit code logic #52402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 2 commits into from
Jan 19, 2026
Merged

Adjust MTP exit code logic #52402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
062ce92
Adjust MTP exit code logic
Youssef1313 Jan 12, 2026
1d8e256
More readable
Youssef1313 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Cli/dotnet/Commands/Test/MTP/MicrosoftTestingPlatformTestCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,13 @@ private int RunInternal(ParseResult parseResult, bool isHelp)
actionQueue.EnqueueCompleted();
// Don't inline exitCode variable. We want to always call WaitAllActions first.
var exitCode = actionQueue.WaitAllActions();
exitCode = _output.HasHandshakeFailure ? ExitCode.GenericFailure : exitCode;

Comment thread
Youssef1313 marked this conversation as resolved.
// If all test apps exited with 0 exit code, but we detected that handshake didn't happen correctly, map that to generic failure.
if (exitCode == ExitCode.Success && _output.HasHandshakeFailure)
{
exitCode = ExitCode.GenericFailure;
}

if (exitCode == ExitCode.Success &&
parseResult.HasOption(MicrosoftTestingPlatformOptions.MinimumExpectedTestsOption) &&
parseResult.GetValue(MicrosoftTestingPlatformOptions.MinimumExpectedTestsOption) is { } minimumExpectedTests &&
Expand Down
Loading