Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the exit code logic for Microsoft Testing Platform (MTP) test runs to preserve specific non-success exit codes when handshake failures occur. Previously, any handshake failure would override the exit code with ExitCode.GenericFailure, but this change only sets GenericFailure when the exit code would have been Success. This addresses issue #52107 where users expect the specific exit code to be preserved when all test applications fail with the same non-zero exit code.
Changes:
- Modified the handshake failure exit code handling to conditionally set
GenericFailureonly when the current exit code isSuccess, preserving specific failure codes otherwise
This was referenced Jan 12, 2026
Evangelink
approved these changes
Jan 17, 2026
mariam-abdulla
approved these changes
Jan 19, 2026
Member
Author
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #52107
But this won't change the behavior described there. This PR will only cause exit code to be transformed to generic failure only in case it would have been a success otherwise.
But if all test apps exited with the same non-success exit code, we will preserve that.