[main] Update dependencies from dotnet/razor

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/razor

• Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
• Build: 20230328.7
• Date Produced: March 29, 2023 5:24:53 AM UTC
• Commit: 3be43f6abbdc8d585f17c168f03b18420aab1062
• Branch: refs/heads/release/dev17.6

• Updates:
  • Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal: from 7.0.0-preview.23167.3 to 7.0.0-preview.23178.7
  • Microsoft.CodeAnalysis.Razor.Tooling.Internal: from 7.0.0-preview.23167.3 to 7.0.0-preview.23178.7
  • Microsoft.NET.Sdk.Razor.SourceGenerators.Transport: from 7.0.0-preview.23167.3 to 7.0.0-preview.23178.7

[nagilson]

Lots 'O test failures here, may you take a peek my friends @dotnet/razor-tooling ?

[davidwengier]

@dotnet/razor-compiler did you want to have a first look?

[nagilson]

Interesting... had no idea what razor-tooling is. but now I know. 😉 Razor.Tooling.Internal being in the list of updates is mildly confusing

[davidwengier]

I admit, I am also confused and surprised by it (such that I edited my comment 😝).

[jjonescz]

The error is

  Could not load file or assembly 'Microsoft.AspNetCore.Razor.Utilities.Shared, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
     at Microsoft.AspNetCore.Razor.Language.DefaultTagHelperDescriptorBuilder.Build()
     at Microsoft.CodeAnalysis.Razor.DefaultTagHelperDescriptorFactory.CreateDescriptor(INamedTypeSymbol type)
     at Microsoft.CodeAnalysis.Razor.DefaultTagHelperDescriptorProvider.Execute(TagHelperDescriptorProviderContext context)
     at Microsoft.CodeAnalysis.Razor.CompilationTagHelperFeature.GetDescriptors()
     at Microsoft.NET.Sdk.Razor.Tool.DiscoverCommand.ExecuteCore(RazorConfiguration configuration, String projectDirectory, String outputFilePath, String[] assemblies) in /_/src/RazorSdk/Tool/DiscoverCommand.cs:line 150
     at Microsoft.NET.Sdk.Razor.Tool.DiscoverCommand.ExecuteCoreAsync() in /_/src/RazorSdk/Tool/DiscoverCommand.cs:line 121
     at Microsoft.NET.Sdk.Razor.Tool.CommandBase.ExecuteAsync() in /_/src/RazorSdk/Tool/CommandBase.cs:line 57
C:\h\w\B9630A53\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.CodeGeneration.targets(97,5): error : rzc discover exited with code 1. [C:\h\w\B9630A53\t\dotnetSdkTests\bps5nxle.fnp\Build_WithP2P---6EDBBC83\ClassLibraryMvc21\ClassLibraryMvc21.csproj]

Looks like the way Razor.Utilities.Shared ships changed in dotnet/razor#8331 which might be the reason.

Guessing something like this could fix the problem: dotnet/razor#8542

I also attempted to fix it here by adding Razor.Utilities.Shared as a dependency of the SDK (e065e7b). That fixed the above error, but another error persisted:

CSC : warning CS8785: Generator 'RazorSourceGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Extensions.ObjectPool, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified. [/private/tmp/helix/working/B70E09F5/w/9C3408A3/e/testExecutionDirectory/Build_Compone---8319F3DC/MvcWithComponents.csproj]
  MvcWithComponents -> /private/tmp/helix/working/B70E09F5/w/9C3408A3/e/testExecutionDirectory/Build_Compone---8319F3DC/bin/Debug/net7.0/MvcWithComponents.dll

Microsoft.Extensions.ObjectPool is a dependency of Razor.Utilities.Shared which is a dependency of the source generator. The ObjectPool dependency was added in dotnet/razor#8284 but that version worked. However, changing how Razor.Utilities.Shared ships later in dotnet/razor#8331 might have broken the source generator here.

[nagilson]

@jjonescz Any updates here? Thanks for taking a look

[jjonescz]

Any updates here?

The PR dotnet/razor#8542 in Razor which should fix this has been merged some time ago. I'm not sure when it'll flow here.

[lewing]

is the razor sdk flowing properly?cc @mmitche

[jjonescz]

Perhaps the bot didn't update since I did a force push on this PR before. So I bumped the versions manually.