Have *.Razor.Utilities.Shared package created #8331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonchou
approved these changes
Feb 24, 2023
davidwengier
approved these changes
Feb 26, 2023
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Will take your word for it :)
Member
Author
|
@dotnet/razor-compiler PTAL |
DustinCampbell
approved these changes
Mar 1, 2023
333fred
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
In order for consumption of Microsoft.VisualStudio.LanguageServer.ContainedLanguage to work, the upstream Microsoft.AspNetCore.Razor.Utilities.Shared needs to be available.
FIX:
Using the build properties that are used heavily in the src\Razor directories, apply to src\Shared.
VALIDATION:
Validated that in local build, the package is produced in the Debug\NonShipping directory and the package contains the correct binary in three different TFMs.