Follow up to global usings changes #19890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When reverting changes to the VisualBasic.targets file, a property initialization was missed. This would have introduced a regression for users upgrading to the 6.0 SDK when they had global imports disabled in their apps. * Only add implicitly enabled imports for C# projects. * Update the stage 0 SDK and re-enable skipped / altered tests Fixes #19793 Fixes #19696
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #19840 to 6.0-rc1
a regression for users upgrading to the 6.0 SDK when they had global imports disabled in their apps.
Fixes #19793
Fixes #19696
Description
Ports fixes and enhancements to ImplictUsings feature that were added in rc1.
a) While undoing some of the changes we made to this feature while making it opt-in, we missed undoing a change to the VB targets. This affects all tfms, so we'd like to get this in.
b) We had a last minute feature request to only define implicitly defined usings for C# projects based on user feedback. This PR adds that change.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
Addresses [issue number]
Fixes #19793
Fixes #19696