Follow up to global usings changes #19840
Conversation
* When reverting changes to the VisualBasic.targets file, a property initialization was missed. This would have introduced a regression for users upgrading to the 6.0 SDK when they had global imports disabled in their apps. * Only add implicitly enabled imports for C# projects. * Update the stage 0 SDK and re-enable skipped / altered tests Fixes #19793 Fixes #19696
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| *********************************************************************************************** | ||
| --> | ||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
This was in the 5.0 SDK - got missed when undoing the changes to VB targets - https://github.com/dotnet/sdk/blob/release/5.0.1xx/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.VisualBasic.targets#L13-L15
| <EnableSourceControlManagerQueries>false</EnableSourceControlManagerQueries> | ||
| <EnableSourceLink>false</EnableSourceLink> | ||
| <DeterministicSourcePaths>false</DeterministicSourcePaths> | ||
| <CheckEolTargetFramework>false</CheckEolTargetFramework> |
There was a problem hiding this comment.
The latest rc1 SDK complains about EOL for 2.1 apps.
|
|
||
| #nullable disable | ||
|
|
||
| using System; |
There was a problem hiding this comment.
Re-adding global usings since they're no longer implicitly added.
Is this because of a workload rename? (@sfoslund?) |
|
@pranavkm most if not all of the tests should use fake manifests, not the ones actually installed in stage 0, so the rename shouldn't theoretically matter. Do you have a link to this test failure? Is it persistent? |
|
It looks like it failed a second time with the same error - https://dev.azure.com/dnceng/public/_build/results?buildId=1302241&view=ms.vss-test-web.build-test-results-tab&runId=38369588&paneView=debug&resultId=101122. |
|
Hmm I don't see any cause right away, but it sounds like @wli3 is going to take a look at the test failures since he's domestic cat and added these tests. |
a regression for users upgrading to the 6.0 SDK when they had global imports disabled in their apps.
Fixes #19793
Fixes #19696