-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Improve isinst expansion #99162
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsSmall change - big (-400kb) diffs. What it does, for // tmp = op1;
// if (tmp != null) // qmarkNull
// {
// if (tmp->pMT == op2) // qmarkMT
// result = tmp;
// else
// result = null;
// }
// else
- // result = tmp;
+ // result = null;
|
@dotnet/jit-contrib PTAL, trivial change with nice diffs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find.
Where does this unblock things? I would have thought RBO would have already handled something like this. Maybe assignments get in the way?
Assertion prop definitly handles this (lcl prop), but looks like it's better to do it early so it can help RBO. My guess that JitOptRepeat would solve this too 🙂 |
Small change - big (-400kb) diffs.
What it does, for
op1 isinst ExactCls
it changes the resulting shape like this: