Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: Regression ObjectStringIsString #99314

Closed
performanceautofiler bot opened this issue Mar 5, 2024 · 5 comments
Closed

[Perf] Linux/x64: Regression ObjectStringIsString #99314

performanceautofiler bot opened this issue Mar 5, 2024 · 5 comments
Assignees
@EgorBo
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime
Milestone
9.0.0

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 5, 2024 •
edited by DrewScoggins
Loading

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline d06ebfee1cfd1ef437784013e93ccfcd31334ac0
Compare 5742895d7c7493dfae4ac40ab36019995d256dd1
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in PerfLabTests.LowLevelPerf

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
109.17 μs 130.99 μs 1.20 0.02 False
109.53 μs 131.42 μs 1.20 0.05 False
154.23 μs 182.39 μs 1.18 0.20 False
65.74 μs 92.93 μs 1.41 0.00 True
525.42 μs 568.86 μs 1.08 0.02 False
109.63 μs 131.04 μs 1.20 0.06 False

graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'PerfLabTests.LowLevelPerf*'

Payloads

Baseline
Compare

PerfLabTests.LowLevelPerf.GenericClassGenericStaticMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.SealedClassInterfaceMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.GenericClassWithSTringGenericInstanceMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.ObjectStringIsString

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.InterfaceInterfaceMethodSwitchCallType

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.GenericClassGenericInstanceMethod

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Mar 5, 2024
@performanceautofiler performanceautofiler bot mentioned this issue Mar 5, 2024
Closed
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Mar 5, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 5, 2024
@DrewScoggins DrewScoggins changed the title [Perf] Linux/x64: 26 Regressions on 2/28/2024 9:23:39 AM [Perf] Linux/x64: Regression ObjectStringIsString Mar 5, 2024
@DrewScoggins
Copy link
Member

Seems like it could be from #99162

@DrewScoggins
Copy link
Member

@EgorBo PTAL

@dotnet dotnet deleted a comment from performanceautofiler bot Mar 5, 2024
@DrewScoggins
Copy link
Member

Windows x64 Regressions - dotnet/perf-autofiling-issues#30485

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 6, 2024
@ghost
Copy link

ghost commented Mar 6, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline d06ebfee1cfd1ef437784013e93ccfcd31334ac0
Compare 5742895d7c7493dfae4ac40ab36019995d256dd1
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in PerfLabTests.LowLevelPerf

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
109.17 μs 130.99 μs 1.20 0.02 False
109.53 μs 131.42 μs 1.20 0.05 False
154.23 μs 182.39 μs 1.18 0.20 False
65.74 μs 92.93 μs 1.41 0.00 True
525.42 μs 568.86 μs 1.08 0.02 False
109.63 μs 131.04 μs 1.20 0.06 False

graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'PerfLabTests.LowLevelPerf*'

Payloads

Baseline
Compare

PerfLabTests.LowLevelPerf.GenericClassGenericStaticMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.SealedClassInterfaceMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.GenericClassWithSTringGenericInstanceMethod

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.ObjectStringIsString

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.InterfaceInterfaceMethodSwitchCallType

ETL Files

Histogram

JIT Disasms

PerfLabTests.LowLevelPerf.GenericClassGenericInstanceMethod

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

os-linux, arch-x64, area-CodeGen-coreclr, untriaged, runtime-coreclr, needs-area-label
Milestone: -

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 12, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Mar 12, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Mar 12, 2024
@EgorBo
Copy link
Member

EgorBo commented Apr 7, 2024

Regression is no more:

image

@EgorBo EgorBo closed this as completed Apr 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
5 participants
@vcsjones @EgorBo @DrewScoggins @jeffschwMSFT @JulieLeeMSFT