Events for IL methods without IL headers #90826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically generated methods like UnsafeAccessor functions are marked as IL, but don't contain an IL header. The lack of header is an indication the IL must be generated at runtime.
|
This also reverts #90801. |
|
There are also two places in the dac that should probably be updated. |
tlakollo
reviewed
Aug 18, 2023
Co-authored-by: Tlakaelel Axayakatl Ceja <[email protected]>
jkotas
reviewed
Aug 18, 2023
jkotas
reviewed
Aug 18, 2023
|
Failure is #90605 |
This was referenced Aug 19, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5912095063 |
This was referenced Sep 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically generated methods like
UnsafeAccessorAttributefunctions are marked as IL, but don't contain an IL header.
The lack of header is an indication the IL must be generated
at runtime.
Fixes #90485
Fixes #90580
Fixes #90593