-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal CLR error (0x80131506) when running IBC collection #90962
Comments
I didn't notice in the stack that we are doing telemetry when this crash happens. Going to add some people from sdk/installer side. Please feel free to add the right people. @marcpopMSFT @elinor-fung. Also adding @mangod9 |
The ExecuteAndCaptureOutput method hasn't changed on the SDK side. We changed the caller of that method slightly to pass in the full path to the application rather than relying on the path. That's the only thing I can think of that changed recently in those code paths. CC @Forgind |
Yeah, I am not convinced that this is from the SDK side, but wanted to make sure, but given that we only see this error when we have the IBC collection infrastructure turned, it seemed unlikely. |
only IBC is failing? I mean MIBC jobs are passing? |
Is there a dump or repro available? Assume its failing consistently? |
As I understand it, that's an access violation: I don't think that would be the result if the file just didn't exist, but I may be wrong. |
This is what is failing. I thought this was technically MIBC. |
I mentioned in the issue how to repro this. I was able to get it quite easily reproed on my machine. |
@marcpopMSFT how do we make dotnet to repeat "first time xp" every launch? Do we need to delete some file in sdk or change config? |
From a quick glance it doesn't look TieredPGO related - still reproduces if I disabel TieredPGO and other flags. |
This is likely the problem fixed by #90826. The fix was checked in 4 days ago. Has the runtime with the fix been ingested into dotnet-optimization? |
dotnet-optimization tried to update to the latest dotnet/installer (yesterday's) that uses dotnet/runtime from this commit: 90b92bb So looks like it doesn't yet include the fix. |
OK. I am going to go ahead and run the LKG runtime through the opt data collection pipeline, and then we will just wait for this change to flow through to installer. I didn't see any PRs in the SDK repo to take an updated version of runtime, but I assume this will land eventually. |
There are three of the sentinels. One for first ruse, one for tool path, and one for aspnet certificate and they are per version of the sdk. If you don't care about being specific (which I would guess you might not), you can probably just delete *sentinel in that folder. |
This is fixed: #89311 (comment) |
Starting between 8.0.100-rc.1.23404.2 and 8.0.100-rc.1.23415.5 the dotnet-optimization runs started failing with the below stack trace.
To repro this you will need to clone the dotnet-optimization repo, and then run
@davidwrighton @jeffschwMSFT
The text was updated successfully, but these errors were encountered: