Disable the "casts between generated and built-in COM interop" analyzer when the "enable interop between generated COM interop and built-in COM interop" feature is enabled. #89125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er when the "enable interop between generated COM interop and built-in COM interop" feature is enabled.
ghost
assigned
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
jkoritzinsky
added
area-System.Runtime.InteropServices
and removed
area-Interop-coreclr
labels
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsUse the property defined in dotnet/sdk#34072 to disable the portion of this analyzer that will have false-positives when the opt-in feature is enabled.
|
jtschuster
approved these changes
Jul 18, 2023
|
I believe we'll already warn when built-in COM is enabled, so I don't think we need to add an additional warning here (as this feature depends on built-in COM being enabled in the first place). |
AaronRobinsonMSFT
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the property defined in dotnet/sdk#34072 to disable the portion of this analyzer that will have false-positives when the opt-in feature is enabled.