Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #87768

Merged
merged 17 commits into from
Jul 10, 2023
Merged

[main] Update dependencies from dotnet/roslyn-analyzers #87768

merged 17 commits into from
Jul 10, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 19, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20230707.1
  • Date Produced: July 7, 2023 2:28:01 PM UTC
  • Commit: 82603c16509d7383cd1922680773a79b839b1705
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
2f7355d 
…uild 20230618.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23318.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jun 19, 2023
@radical
Copy link
Member

radical commented Jun 19, 2023

WasmBuildTests failure can be ignored. The wasm/runtimetests build likely hit resource limits.

@build-analysis build-analysis bot mentioned this pull request Jun 19, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
a82e1b6 
…uild 20230619.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23319.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
18b3e3a 
…uild 20230620.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23320.2
@stephentoub
Copy link
Member

@buyaa-n, it looks like a bug was introduced into CA1861 and it's now flagging array allocations like new Type[length] as part of method calls.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
7c214eb 
…uild 20230621.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23321.2
@build-analysis build-analysis bot mentioned this pull request Jun 23, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
d5241a0 
…uild 20230623.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23323.2
This was referenced Jun 26, 2023
Closed
Merged
@buyaa-n
Copy link
Contributor

buyaa-n commented Jun 27, 2023

@buyaa-n, it looks like a bug was introduced into CA1861 and it's now flagging array allocations like new Type[length] as part of method calls.

Thanks, it will be fixed with dotnet/roslyn-analyzers#6714

Tagging @sharwell for RS1038 failures:

src\libraries\System.Runtime.InteropServices\gen\LibraryImportGenerator\Analyzers\ConvertToLibraryImportAnalyzer.cs(17,6): warning RS1038: This compiler extension should not be implemented in an assembly containing a reference to Microsoft.CodeAnalysis.Wo
rkspaces. The Microsoft.CodeAnalysis.Workspaces assembly is not provided during command line compilation scenarios, so references to it could cause the compiler extension to behave unpredictably.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
b70a82a 
…uild 20230627.4

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23327.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ee99554 
…uild 20230628.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23328.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
bd67cd9 
…uild 20230629.4

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23329.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
906b889 
…uild 20230630.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.3.5-beta1.23330.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
409962a 
…uild 20230703.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.11.0-beta1.23353.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
a1e864a 
…uild 20230705.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.11.0-beta1.23355.1
@build-analysis build-analysis bot mentioned this pull request Jul 5, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
be50358 
…uild 20230706.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.11.0-beta1.23356.2
@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 7, 2023

@jkoritzinsky analyzers in LibraryImportGenerator are failing with RS1038 warning, could you take a look?

src\libraries\System.Runtime.InteropServices\gen\LibraryImportGenerator\Analyzers\ConvertToLibraryImportAnalyzer.cs(17,6): warning RS1038: This compiler extension should not be implemented in an assembly containing a reference to Microsoft.CodeAnalysis.Wo
rkspaces. The Microsoft.CodeAnalysis.Workspaces assembly is not provided during command line compilation scenarios, so references to it could cause the compiler extension to behave unpredictably.

@jkoritzinsky
Copy link
Member

I'm out of the office until next week. You can suppress the issue and file a follow up for me to do later. Or @sharwell can probably help resolve the problems.

@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 7, 2023

I'm out of the office until next week. You can suppress the issue and file a follow up for me to do later. Or @sharwell can probably help resolve the problems.

Thanks, I am going to suppress the warning and file an issue for follow up.

buyaa-n
buyaa-n approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold of merging and let area owners review the fixes for CA1859: Use concrete types when possible for improved performance diagnostics.

Failures unrelated and known

@build-analysis build-analysis bot mentioned this pull request Jul 8, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
3d61a60 
…uild 20230707.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23308.2 -> To Version 3.11.0-beta1.23357.1
@build-analysis build-analysis bot mentioned this pull request Jul 8, 2023
Closed
@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 10, 2023

Failures unrelated and known, merging to unblock the code flow, if there is any feedback we can apply them later

@buyaa-n buyaa-n merged commit 54cb573 into main Jul 10, 2023
@buyaa-n buyaa-n deleted the darc-main-168fbb49-c4dd-4ee3-aa49-17b851f65f6c branch July 10, 2023 20:38
@buyaa-n buyaa-n mentioned this pull request Jul 11, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @stephentoub @buyaa-n @jkoritzinsky