CA1861: Do not warn if not an array initializer. #6714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6714 +/- ##
=======================================
Coverage 96.36% 96.37%
=======================================
Files 1390 1390
Lines 324039 324042 +3
Branches 10613 10613
=======================================
+ Hits 312274 312287 +13
+ Misses 9224 9214 -10
Partials 2541 2541 |
stephentoub
reviewed
Jun 27, 2023
| public List<object> Cases => new() { {|CA1861:new object[0]|} }; | ||
| }"; | ||
| var fixedSource = @"using System.Collections.Generic; | ||
| public List<object> Cases => new() { new object[0] }; |
There was a problem hiding this comment.
This should trigger CA1825 (https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1825). Do we know why it doesn't?
There was a problem hiding this comment.
I think it is expected for unit testing, I did not see any unrelated diagnostics triggered in unit testing except compiler warnings. By my understanding the unit tests only trigger the diagnostics related to:
In normal case the CA1825 is being triggered:
mavasani
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA1861:
Avoid constant arrays as argumentsanalyzer should not warn when the array creation has no array initializer.Fixes #6697
Related to dotnet/runtime#87768 (comment)