-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreCLR/NativeAOT] UnsafeAccessorAttribute
non-generic support
#86932
[CoreCLR/NativeAOT] UnsafeAccessorAttribute
non-generic support
#86932
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0e18368 - Browse repository at this point
Copy the full SHA 0e18368View commit details -
Prototype for UnsafeAccessorAttribute
- Hardcoded to default ctor
Configuration menu - View commit details
-
Copy full SHA for 292da73 - Browse repository at this point
Copy the full SHA 292da73View commit details -
Remove IsUnsafeAccessor flag from MethodDesc
and instead encode details on the scopeHandle.
Configuration menu - View commit details
-
Copy full SHA for 40111fa - Browse repository at this point
Copy the full SHA 40111faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0191e0d - Browse repository at this point
Copy the full SHA 0191e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef239fb - Browse repository at this point
Copy the full SHA ef239fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a396e04 - Browse repository at this point
Copy the full SHA a396e04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6437420 - Browse repository at this point
Copy the full SHA 6437420View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24717a - Browse repository at this point
Copy the full SHA b24717aView commit details -
Configuration menu - View commit details
-
Copy full SHA for edd7fb7 - Browse repository at this point
Copy the full SHA edd7fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a9ef3 - Browse repository at this point
Copy the full SHA 03a9ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d771f04 - Browse repository at this point
Copy the full SHA d771f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02267ff - Browse repository at this point
Copy the full SHA 02267ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for e911d3a - Browse repository at this point
Copy the full SHA e911d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6dbb50 - Browse repository at this point
Copy the full SHA c6dbb50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9864b45 - Browse repository at this point
Copy the full SHA 9864b45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60c38dd - Browse repository at this point
Copy the full SHA 60c38ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b9c75 - Browse repository at this point
Copy the full SHA 10b9c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e9ee12 - Browse repository at this point
Copy the full SHA 3e9ee12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f9e81 - Browse repository at this point
Copy the full SHA 62f9e81View commit details -
Configuration menu - View commit details
-
Copy full SHA for a506601 - Browse repository at this point
Copy the full SHA a506601View commit details -
Apply suggestions from code review
Co-authored-by: Stephen Toub <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8c94bf - Browse repository at this point
Copy the full SHA b8c94bfView commit details -
Apply suggestions from code review
Co-authored-by: Stephen Toub <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 636e616 - Browse repository at this point
Copy the full SHA 636e616View commit details -
Add error message for invalid UnsafeAccessor use
Additional negative tests Specifically block array and pointer types Consolidate JIT flag lookup
Configuration menu - View commit details
-
Copy full SHA for 72bc7f5 - Browse repository at this point
Copy the full SHA 72bc7f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2859b6e - Browse repository at this point
Copy the full SHA 2859b6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 331f4cc - Browse repository at this point
Copy the full SHA 331f4ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for c01080e - Browse repository at this point
Copy the full SHA c01080eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d5c1ab - Browse repository at this point
Copy the full SHA 1d5c1abView commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34ada73 - Browse repository at this point
Copy the full SHA 34ada73View commit details -
Configuration menu - View commit details
-
Copy full SHA for a56bc40 - Browse repository at this point
Copy the full SHA a56bc40View commit details -
Remove ctor special case lookup
Add runtime sniff test for UnsafeAccessor scenarios Add call ctor as method test
Configuration menu - View commit details
-
Copy full SHA for a43b3cc - Browse repository at this point
Copy the full SHA a43b3ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da55de - Browse repository at this point
Copy the full SHA 3da55deView commit details
Commits on Jun 7, 2023
-
Collect custom modifiers counts
Permit ignoring custom modifiers during comparison
Configuration menu - View commit details
-
Copy full SHA for bbe820c - Browse repository at this point
Copy the full SHA bbe820cView commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18a2749 - Browse repository at this point
Copy the full SHA 18a2749View commit details -
Defined ambiguity logic with respect to
custom modifiers. - First pass ignore custom modifiers - If ambiguity detected, rerun algorithm but require precise matching of custom modifiers. - If there is no clear match throw AmbiguousImplementationException.
Configuration menu - View commit details
-
Copy full SHA for d5ff647 - Browse repository at this point
Copy the full SHA d5ff647View commit details -
Configuration menu - View commit details
-
Copy full SHA for 924cf37 - Browse repository at this point
Copy the full SHA 924cf37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 305aeff - Browse repository at this point
Copy the full SHA 305aeffView commit details -
Configuration menu - View commit details
-
Copy full SHA for c169969 - Browse repository at this point
Copy the full SHA c169969View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3691f - Browse repository at this point
Copy the full SHA 3b3691fView commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f0756b7 - Browse repository at this point
Copy the full SHA f0756b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c51e986 - Browse repository at this point
Copy the full SHA c51e986View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ba472 - Browse repository at this point
Copy the full SHA 12ba472View commit details -
Configuration menu - View commit details
-
Copy full SHA for efb27a4 - Browse repository at this point
Copy the full SHA efb27a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3b0726 - Browse repository at this point
Copy the full SHA d3b0726View commit details
Commits on Jun 10, 2023
-
Remove catch all for any exception. This code
path has evolved to require exceptions to propagate for generation of typeload exception stub.
Configuration menu - View commit details
-
Copy full SHA for 56d733e - Browse repository at this point
Copy the full SHA 56d733eView commit details -
Configuration menu - View commit details
-
Copy full SHA for facc48e - Browse repository at this point
Copy the full SHA facc48eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d92e7e - Browse repository at this point
Copy the full SHA 8d92e7eView commit details
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b446a20 - Browse repository at this point
Copy the full SHA b446a20View commit details -
Missed fallback name lookup on NativeAOT.
Added tests for pointer types and declaration name lookup.
Configuration menu - View commit details
-
Copy full SHA for 5b67d04 - Browse repository at this point
Copy the full SHA 5b67d04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3663bad - Browse repository at this point
Copy the full SHA 3663badView commit details -
Remove block of doc text for generics. Will add
back when supported is added.
Configuration menu - View commit details
-
Copy full SHA for c2be6fc - Browse repository at this point
Copy the full SHA c2be6fcView commit details
Commits on Jun 13, 2023
-
Treat signature calling convention bits like we treat
custom modifiers during method lookup.
1Configuration menu - View commit details
-
Copy full SHA for 63f975c - Browse repository at this point
Copy the full SHA 63f975cView commit details -
Managed and unmanaged function pointers never
signature match.
Configuration menu - View commit details
-
Copy full SHA for 869a5f0 - Browse repository at this point
Copy the full SHA 869a5f0View commit details -
Feedback for throwing exceptions on NativeAOT
Remove unmanage resource string and move it to SPCL Share the AmbiguousMatchException message between NativeAOT and CoreCLR.
Configuration menu - View commit details
-
Copy full SHA for c03dc9e - Browse repository at this point
Copy the full SHA c03dc9eView commit details
Commits on Jun 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a309b06 - Browse repository at this point
Copy the full SHA a309b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for b957416 - Browse repository at this point
Copy the full SHA b957416View commit details