-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreCLR/NativeAOT] UnsafeAccessorAttribute
non-generic support
#86932
[CoreCLR/NativeAOT] UnsafeAccessorAttribute
non-generic support
#86932
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
/// <summary> | ||
/// Provide access to a Method. | ||
/// </summary> | ||
Method, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this any method or just instance method? The naming is strange if it's the latter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for an instance method. That is what API decided upon. I can go back and ask if you think InstanceMethod
is more appropriate?
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So reminiscent of the old days ...
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
path has evolved to require exceptions to propagate for generation of typeload exception stub.
Add test for validation
Added tests for pointer types and declaration name lookup.
back when supported is added.
custom modifiers during method lookup.
signature match.
Remove unmanage resource string and move it to SPCL Share the AmbiguousMatchException message between NativeAOT and CoreCLR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your work on this feature!
@MichalStrehovsky Can you take another look at the NativeAOT portions? I'd like a sign off from you too with respect to how this is implemented there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
UnsafeAccessorAttribute
non-generic supportUnsafeAccessorAttribute
non-generic support
Contributes to #86161