Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented May 29, 2023

Backport of #86789 to release/7.0-staging

Customer Impact
Fixes #86765.

Testing
automated:
./dotnet.sh test ./src/mono/wasm/debugger/DebuggerTestSuite -bl --filter DebuggerTests.MiscTests -e RuntimeConfiguration=Release -e Configuration=Debug -e DebuggerHost=chrome

Risk
Small, it's adding safety measures for a cast.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels May 29, 2023
@ilonatommy ilonatommy self-assigned this May 29, 2023
@ghost
Copy link

ghost commented May 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of https://github.com/dotnet/runtime/pull/85677 and https://github.com/dotnet/runtime/pull/85660 to release/7.0-staging

Customer Impact
Fixes #86765.

Testing
automated:
./dotnet.sh test ./src/mono/wasm/debugger/DebuggerTestSuite -bl --filter DebuggerTests.MiscTests -e RuntimeConfiguration=Release -e Configuration=Debug -e DebuggerHost=chrome

Risk
Small, it's adding safety measures for a cast.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@lewing lewing changed the title [mono][debugger] Remove cast bug [release/7.0-staging][mono][debugger] Remove cast bug May 29, 2023
@lewing lewing added the Servicing-consider Issue for next servicing release review label May 29, 2023
@lewing lewing added this to the 7.0.x milestone May 29, 2023
@ilonatommy ilonatommy added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 30, 2023
@ilonatommy
Copy link
Member Author

Timeouting job was checked locally and it passes.

@ilonatommy ilonatommy merged commit 527cd69 into dotnet:release/7.0-staging Jun 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants