Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented May 26, 2023

Fixes #86765.

We had an exception on operation metadataReader.GetTypeReference((TypeReferenceHandle)container.Value).Name - while for regular custom attributes the type there was TypeReference, for generic custom attributes from the issue it was TypeSpecification (unable to cast).

@ilonatommy ilonatommy requested a review from thaystg as a code owner May 26, 2023 11:45
@ilonatommy ilonatommy self-assigned this May 26, 2023
@ilonatommy ilonatommy requested a review from radical as a code owner May 26, 2023 11:45
@ghost
Copy link

ghost commented May 26, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86765.

Author: ilonatommy
Assignees: ilonatommy
Labels:

area-Debugger-mono

Milestone: -

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

Failures: multithreaded debugger + SetBreakpointInProjectWithSpecialCharactersInPath - not connected.

@ilonatommy ilonatommy merged commit 58e5850 into dotnet:main May 26, 2023
@lewing
Copy link
Member

lewing commented May 26, 2023

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5093384105

@github-actions
Copy link
Contributor

@lewing backporting to release/7.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix.
Using index info to reconstruct a base tree...
M	src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
CONFLICT (content): Merge conflict in src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@lewing an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

ilonatommy added a commit to ilonatommy/runtime that referenced this pull request May 29, 2023
@radical
Copy link
Member

radical commented May 30, 2023

@ilonatommy Could you please add some details to the PR description?

ilonatommy added a commit that referenced this pull request Jun 6, 2023
* Backporting #86789.

* In net8 these are running only on Chrome.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor Wasm: debugging broken by attribute with type parameter

4 participants