Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-distro-rid.sh: fix unbound error when VERSION_ID is not defined. #85319

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

tmds
Copy link
Member

@tmds tmds commented Apr 25, 2023

Fixes #85315.

I verified this locally.

@ViktorHofer ptal.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 25, 2023
@tmds
Copy link
Member Author

tmds commented Apr 25, 2023

cc @ManickaP

@tmds tmds force-pushed the distrorid_versionid_unbound branch from 520181c to 095c82c Compare April 25, 2023 13:29
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just tested it locally and it works for me.

@tmds
Copy link
Member Author

tmds commented Apr 25, 2023

fyi, #82832 didn't change this code, but caused it to run also on portable builds.

@ViktorHofer ViktorHofer merged commit 5191a75 into dotnet:main Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken build on Arch Linux
3 participants