Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken build on Arch Linux #85315

Closed
ManickaP opened this issue Apr 25, 2023 · 2 comments · Fixed by #85319
Closed

Broken build on Arch Linux #85315

ManickaP opened this issue Apr 25, 2023 · 2 comments · Fixed by #85319
Labels
area-Infrastructure-libraries

Comments

@ManickaP
Copy link
Member

I assume this will be problem for any rolling distro, not just Arch Linux. VERSION_ID is optional in /etc/os-release: https://www.freedesktop.org/software/systemd/man/os-release.html#VERSION_ID. And together with set -u in build.sh:

runtime/eng/build.sh

Line 3 in 19d545c

set -ue

results in:

/home/manicka/repositories/runtime.2/eng/native/init-distro-rid.sh: line 28: VERSION_ID: unbound variable

@tmds @ViktorHofer I suspect #82832 PR broke it.

I can workaround it locally with removing set -u, but I'm not sure if that's what you'd prefer as a solution.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

I assume this will be problem for any rolling distro, not just Arch Linux. VERSION_ID is optional in /etc/os-release: https://www.freedesktop.org/software/systemd/man/os-release.html#VERSION_ID. And together with set -u in build.sh:

runtime/eng/build.sh

Line 3 in 19d545c

set -ue

results in:

/home/manicka/repositories/runtime.2/eng/native/init-distro-rid.sh: line 28: VERSION_ID: unbound variable

@tmds @ViktorHofer I suspect #82832 PR broke it.

I can workaround it locally with removing set -u, but I'm not sure if that's what you'd prefer as a solution.

Author: ManickaP
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ViktorHofer
Copy link
Member

@tmds can you please take a look?

cc @akoeplinger and @am11 just FYI

@tmds tmds mentioned this issue Apr 25, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 25, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

init-distro-rid.sh: fix unbound error when VERSION_ID is not defined. tmds/runtime
2 participants
@ViktorHofer @ManickaP