-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][interp] Fix arg alignment issues when mixing with compiled code #85153
Merged
Commits on May 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ecc9291 - Browse repository at this point
Copy the full SHA ecc9291View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70615b1 - Browse repository at this point
Copy the full SHA 70615b1View commit details -
[mono][interp] Move mint_type out from header file
It makes no sense to inline this big method into callers.
Configuration menu - View commit details
-
Copy full SHA for bf05a8c - Browse repository at this point
Copy the full SHA bf05a8cView commit details -
[mono][interp] Fix arg offset computation when doing pinvoke and aot/…
…jit calls from interp The previous code wasn't handling alignment of simd types.
Configuration menu - View commit details
-
Copy full SHA for 604f528 - Browse repository at this point
Copy the full SHA 604f528View commit details -
[mono][interp] Use the correct alignment for args when entering interp
We stop computing the arguments on the fly since it's getting too expensive doing the alignment checks. We directly use `imethod->arg_offsets` instead which is computed once during the first call, while also ensuring consistency with the calculation.
Configuration menu - View commit details
-
Copy full SHA for f1e7a01 - Browse repository at this point
Copy the full SHA f1e7a01View commit details -
Configuration menu - View commit details
-
Copy full SHA for a296fbc - Browse repository at this point
Copy the full SHA a296fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8452132 - Browse repository at this point
Copy the full SHA 8452132View commit details -
Configuration menu - View commit details
-
Copy full SHA for 617cc22 - Browse repository at this point
Copy the full SHA 617cc22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e4de7 - Browse repository at this point
Copy the full SHA 23e4de7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4724c3e - Browse repository at this point
Copy the full SHA 4724c3eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.