Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][interp] Fix arg alignment issues when mixing with compiled code #85153

Merged
merged 10 commits into from
May 8, 2023
Merged

[mono][interp] Fix arg alignment issues when mixing with compiled code #85153

merged 10 commits into from
May 8, 2023

Commits on May 8, 2023

  1. [mono][interp] Refactor arg offset computation to make code clearer

    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ecc9291 View commit details
    Browse the repository at this point in the history

  2. [mono][interp] Remove redundant assign

    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    70615b1 View commit details
    Browse the repository at this point in the history

  3. [mono][interp] Move mint_type out from header file 

    It makes no sense to inline this big method into callers.
    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    bf05a8c View commit details
    Browse the repository at this point in the history

  4. [mono][interp] Fix arg offset computation when doing pinvoke and aot/… 

    …jit calls from interp

The previous code wasn't handling alignment of simd types.
    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    604f528 View commit details
    Browse the repository at this point in the history

  5. [mono][interp] Use the correct alignment for args when entering interp 

    We stop computing the arguments on the fly since it's getting too expensive doing the alignment checks. We directly use `imethod->arg_offsets` instead which is computed once during the first call, while also ensuring consistency with the calculation.
    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f1e7a01 View commit details
    Browse the repository at this point in the history

  6. [mono][interp] Fix arg offset computation when running clauses with i… 

    …nterp
    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    a296fbc View commit details
    Browse the repository at this point in the history

  7. [mono][interp] Remove dead code

    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8452132 View commit details
    Browse the repository at this point in the history

  8. Temporaril disable jiterp for CI

    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    617cc22 View commit details
    Browse the repository at this point in the history

  9. Update jiterpreter interp_entry wrapper generator and re-enable jiterp

    @kg @BrzVlad
    kg authored and BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    23e4de7 View commit details
    Browse the repository at this point in the history

  10. Revert options-def.h changes

    @BrzVlad
    BrzVlad committed May 8, 2023
    Configuration menu
    Copy the full SHA
    4724c3e View commit details
    Browse the repository at this point in the history