[mono][interp] Fix arg alignment issues when mixing with compiled code #85153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue Detailsnull
|
This was referenced Apr 21, 2023
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
from
a6377c2
to
c3b955b
Compare
This was referenced Apr 21, 2023
This was referenced Apr 21, 2023
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
from
c3b955b
to
687177e
Compare
|
I don't know how to push to your PR, but try ee96093 to update the jiterpreter and turn it all back on. I did some basic testing in AOT mode (the affected part, I think) and it seems to work now. You'll want to revert the changes to the threshold + stats options in options-def before merging (I lowered the threshold to make sure we actually exercise it during test runs) |
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
2 times, most recently
from
7f53ee9
to
45ee68a
Compare
BrzVlad
requested review from
lewing,
pavelsavara,
kg,
vargaz,
lambdageek and
kotlarmilos
as code owners
kg
reviewed
May 6, 2023
src/mono/mono/utils/options-def.h
Outdated
| @@ -95,7 +95,7 @@ DEFINE_BOOL(jiterpreter_call_resume_enabled, "jiterpreter-call-resume-enabled", | |||
| // stats for options like estimateHeat, but raises overhead. | |||
| DEFINE_BOOL(jiterpreter_disable_heuristic, "jiterpreter-disable-heuristic", FALSE, "Always insert trace entry points for more accurate statistics") | |||
| // Automatically prints stats at app exit or when jiterpreter_dump_stats is called | |||
| DEFINE_BOOL(jiterpreter_stats_enabled, "jiterpreter-stats-enabled", FALSE, "Automatically print jiterpreter statistics") | |||
| DEFINE_BOOL(jiterpreter_stats_enabled, "jiterpreter-stats-enabled", TRUE, "Automatically print jiterpreter statistics") | |||
There was a problem hiding this comment.
The changes to options-def can be reverted now that the tests passed on CI
kg
reviewed
May 6, 2023
kg
approved these changes
May 6, 2023
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
from
d503577
to
c5c55ab
Compare
It makes no sense to inline this big method into callers.
…jit calls from interp The previous code wasn't handling alignment of simd types.
We stop computing the arguments on the fly since it's getting too expensive doing the alignment checks. We directly use `imethod->arg_offsets` instead which is computed once during the first call, while also ensuring consistency with the calculation.
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
from
c5c55ab
to
edfc973
Compare
kotlarmilos
reviewed
May 8, 2023
BrzVlad
force-pushed
the
fix-interp-simd-alignment
branch
from
edfc973
to
4724c3e
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.