Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start running Loader and Interop tests for NativeAOT #84404

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Start running Loader and Interop tests for NativeAOT #84404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3057487
Start running Loader and Interop tests for NativeAOT
MichalStrehovsky Apr 6, 2023
69bd4da
Update runtime.yml
MichalStrehovsky Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ extends:
extraStepsTemplate: /eng/pipelines/coreclr/nativeaot-post-build-steps.yml
extraStepsParameters:
creator: dotnet-bot
testBuildArgs: nativeaot tree nativeaot /p:BuildNativeAotFrameworkObjects=true
testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;" /p:BuildNativeAotFrameworkObjects=true'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/runtime-infrastructure are we using the semicolon-delimited list as an argument to test build tree somewhere?

I was having trouble getting it to work - cmd.exe considers semicolons the same as space when it comes to %1 %2 argument processing (today I learned...) so it has to be quoted. But then nobody removed the quote and MSBuild was looking for directory "nativeat. Adding an extra empty entry like I'm doing here hacks around it but I wonder if we should find a different list separator.

liveLibrariesBuildConfig: Release
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
extraVariablesTemplates:
Expand Down
10 changes: 10 additions & 0 deletions src/tests/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,16 @@

<!-- Bump the generic cycle tolerance. There's at least one test with a cycle that is reachable at runtime to depth 6 -->
<IlcArg Include="--maxgenericcycle:7" />

<!-- We set TrimMode to partial so that we don't trim parts of the tests,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 5-10% compile time saving...

but don't make this apply to xunit cruft -->
<IlcArg Include="--trim:Microsoft.DotNet.XUnitExtensions" />
<IlcArg Include="--trim:xunit.abstractions" />
<IlcArg Include="--trim:xunit.assert" />
<IlcArg Include="--trim:xunit.console" />
<IlcArg Include="--trim:xunit.core" />
<IlcArg Include="--trim:xunit.execution.dotnet" />
<IlcArg Include="--trim:xunit.abstractions" />
</ItemGroup>

<Import Project="$(CoreCLRBuildIntegrationDir)Microsoft.DotNet.ILCompiler.SingleEntry.targets" Condition="'$(TestBuildMode)' == 'nativeaot'" />
Expand Down