Start running Loader and Interop tests for NativeAOT #84404
Conversation
ghost
assigned
src/tests/Loader/classloader/MethodImpl/CovariantReturns/Interfaces/UnitTest.il
Outdated
Show resolved
Hide resolved
| @@ -546,6 +546,16 @@ | |||
|
|
|||
| <!-- Bump the generic cycle tolerance. There's at least one test with a cycle that is reachable at runtime to depth 6 --> | |||
| <IlcArg Include="--maxgenericcycle:7" /> | |||
|
|
|||
| <!-- We set TrimMode to partial so that we don't trim parts of the tests, | |||
There was a problem hiding this comment.
This is a 5-10% compile time saving...
| @@ -246,7 +246,7 @@ extends: | |||
| extraStepsTemplate: /eng/pipelines/coreclr/nativeaot-post-build-steps.yml | |||
| extraStepsParameters: | |||
| creator: dotnet-bot | |||
| testBuildArgs: nativeaot tree nativeaot /p:BuildNativeAotFrameworkObjects=true | |||
| testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;" /p:BuildNativeAotFrameworkObjects=true' | |||
There was a problem hiding this comment.
@dotnet/runtime-infrastructure are we using the semicolon-delimited list as an argument to test build tree somewhere?
I was having trouble getting it to work - cmd.exe considers semicolons the same as space when it comes to %1 %2 argument processing (today I learned...) so it has to be quoted. But then nobody removed the quote and MSBuild was looking for directory "nativeat. Adding an extra empty entry like I'm doing here hacks around it but I wonder if we should find a different list separator.
These are the most interesting ones to cover in regular testing.
MichalStrehovsky
force-pushed
the
runloaderinterop
branch
from
1f87a31
to
3057487
Compare
|
@dotnet/ilc-contrib this is ready for review. There's not much to review left since I factored out things that were necessary for tests to pass into separate PRs. |
Can someone have a look please? I'd honestly merge without review because this is de minimis test only change but repo is configured not to allow that. We need to start making progress on the Pri0 testing. |
|
How much CI and Helix machine time do these tests cost? |
|
They build and run in about 10 minutes on my machine. The Win-Amd64-chk leg (the only one that is going to run these) doesn't look to be running too much longer than usual. |
|
Thank you! |
These are the most interesting ones to cover in regular testing.
Cc @dotnet/ilc-contrib