Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pal_console.c: cast TIOCSWINSZ to int when HAVE_IOCTL_WITH_INT_REQUEST #82676

Merged
merged 1 commit into from
Feb 27, 2023
Merged

pal_console.c: cast TIOCSWINSZ to int when HAVE_IOCTL_WITH_INT_REQUEST #82676

merged 1 commit into from
Feb 27, 2023

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Feb 25, 2023 •
edited
Loading

Adds missing cast to int when HAVE_IOCTL_WITH_INT_REQUEST

Related to #82173

Per @am11:

On some Unix-likes, such as linux with musl-libc and illumos, the second argument of ioctl is
int request instead of unsigned long request.

/cc: @Sapana-Khemkar

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2023
@ayakael ayakael changed the title pal_console.c: cast TIOCSWINSZ to int when HAVE_IOCTL_WITH_INT_REQUEST pal_console.c: cast TIOCSWINSZ to int when HAVE_IOCTL_WITH_INT_REQUEST Feb 25, 2023
@stephentoub stephentoub merged commit fb13c2c into dotnet:main Feb 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayakael @stephentoub