Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake check for ioclt prototype #82173

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 15, 2023

Fix #82161.

On some Unix-likes, such as linux with musl-libc and illumos, the second argument of ioctl is int request instead of unsigned long request.

Thanks to @uweigand for investigating what's going on: #76500 (comment).

FYI @Sapana-Khemkar @ayakael

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@am11 am11 requested a review from janvorli February 15, 2023 15:56
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 15, 2023
@ghost
Copy link

ghost commented Feb 15, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #82161.

On some Unix-likes, such as linux with mul-libc and illumos, the second argument of ioctl is int request instead of unsigned long request.

Thanks to @uweigand for investigating what's going on: #76500 (comment).

FYI @Sapana-Khemkar @ayakael

Author: am11
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@am11
Copy link
Member Author

am11 commented Feb 15, 2023

linux-arm64 test failure is unrelated: #81123.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 4e0ff82 into dotnet:main Feb 16, 2023
@ayakael ayakael mentioned this pull request Feb 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-community pipeline fails to build
2 participants