Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix ConnectAsync with buffer on Windows #79866

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 20, 2022

Backport of #79669 to release/7.0

/cc @antonfirsov

Fixes #79654.

Customer Impact

On Windows it's possible to send an initial buffer during ConnectAsync via SocketAsyncEventArgs.SetBuffer(), which regressed in 7.0, making such connection attempts to fail.

Testing

The PR adds a test case for the scenario.

Risk

Very low, we are combining the old behavior with the new pinning mechanism.

@ghost
Copy link

ghost commented Dec 20, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79669 to release/7.0

/cc @antonfirsov

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@antonfirsov antonfirsov added the Servicing-consider Issue for next servicing release review label Jan 4, 2023
@rbhanda rbhanda added this to the 7.0.3 milestone Jan 5, 2023
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 5, 2023
@carlossanlop
Copy link
Member

Approved by Tactics (7.0.3).
Signed off by area owner.
No OOB changes needed - The involved src csproj does not have IsPackable=true.
CI failures unrelated: One is known/unrelated/already fixed #78778, the other is an unrelated browser failure in System.Runtime staging (build log too old, could not find detailed failure message).
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 0776945 into release/7.0 Jan 5, 2023
@carlossanlop carlossanlop deleted the backport/pr-79669-to-release/7.0 branch January 5, 2023 19:48
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Sockets Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants