Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConnectAsync with buffer on Windows #79669

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix ConnectAsync with buffer on Windows #79669

merged 2 commits into from
Dec 20, 2022

Conversation

antonfirsov
Copy link
Member

Fixes #79654

@ghost ghost assigned antonfirsov Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #79654

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets
Milestone: -

@antonfirsov antonfirsov mentioned this pull request Dec 14, 2022
Closed
This was referenced Dec 14, 2022
Closed
Closed
@mgravell
Copy link
Member

LGTM 👍

wfurt
wfurt approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

Test failures are unrelated (#73721, #79731, #77414, #77012, #79820, #79749 and others from outerloop).

@antonfirsov antonfirsov merged commit 82e9d38 into dotnet:main Dec 20, 2022
@antonfirsov
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3743745790

@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@liveans liveans liveans approved these changes

Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Sockets
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Socket connect with payload via SocketAsyncEventArgs fails
5 participants
@antonfirsov @mgravell @wfurt @liveans @karelz