Skip to content

Avoid boxing in DeferredDisposableLifetime #79778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Avoid boxing in DeferredDisposableLifetime #79778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc327f8
Avoid boxing in DeferredDisposableLifetime
MihaZupan Dec 17, 2022
0e9ea64
Move `typeof` lookup behind the if check
MihaZupan Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Threading/DeferredDisposableLifetime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public bool AddRef()
int oldCount = Volatile.Read(ref _count);

// Have we been disposed?
ObjectDisposedException.ThrowIf(oldCount < 0, this);
if (oldCount < 0)
throw new ObjectDisposedException(typeof(T).ToString());
Copy link
Member

@stephentoub stephentoub Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. We'll want to fix the analyzer/fixer as well to not fire in this case. But that's not pressing and I can do that when I'm back.

Copy link
Member

@stephentoub stephentoub Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to fix the analyzer/fixer as well to not fire in this case. But that's not pressing and I can do that when I'm back.

dotnet/roslyn-analyzers#6396


int newCount = checked(oldCount + 1);

Expand Down