Avoid boxing in DeferredDisposableLifetime #79778
Conversation
|
Tagging subscribers to this area: @mangod9 Issue DetailsFixes #79774
void ThrowIf(bool condition, object instance);
void ThrowIf(bool condition, Type type);
|
|
/benchmark json aspnet-citrine-win runtime |
|
I was staring at the original PR trying to figure out what was going on 😄 |
|
cc @stephentoub |
|
Benchmark started for json on aspnet-citrine-win with runtime. Logs: link |
|
An error occured, please check the logs |
|
src/libraries/System.Private.CoreLib/src/System/Threading/DeferredDisposableLifetime.cs
Outdated
Show resolved
Hide resolved
|
Here you go
|
|
|
|
Imagine if we had an analyzer for this 😄 (https://marketplace.visualstudio.com/items?itemName=MukulSabharwal.ClrHeapAllocationAnalyzer&ssr=false#overview) cc @mjsabby |
| // Have we been disposed? | ||
| ObjectDisposedException.ThrowIf(oldCount < 0, this); | ||
| if (oldCount < 0) | ||
| throw new ObjectDisposedException(typeof(T).ToString()); |
There was a problem hiding this comment.
Thanks for fixing. We'll want to fix the analyzer/fixer as well to not fire in this case. But that's not pressing and I can do that when I'm back.
There was a problem hiding this comment.
We'll want to fix the analyzer/fixer as well to not fire in this case. But that's not pressing and I can do that when I'm back.
|
Whoa, that was a large regression due to a one line change. Are there other places which need to be looked at, since the original change had a lot more changes? |
|
I scanned through the |
ghost
locked as resolved and limited conversation to collaborators
6 participants
Fixes #79774
thisin this case is a struct, andObjectDisposedExceptionhas two overloads