Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up members/signatures/visibility in deps_format/resolver #78572

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Clean up members/signatures/visibility in deps_format/resolver #78572

merged 2 commits into from
Nov 22, 2022

Conversation

elinor-fung
Copy link
Member

Slight cleanup of deps_format/deps_resolver:

  • Remove unnecessary copying of paths into members in deps_resolver
  • Remove returns in deps_format load/process functions (always returning true)
  • Make members private when possible

@ghost ghost assigned elinor-fung Nov 18, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Slight cleanup of deps_format/deps_resolver:

  • Remove unnecessary copying of paths into members in deps_resolver
  • Remove returns in deps_format load/process functions (always returning true)
  • Make members private when possible
Author: elinor-fung
Assignees: -
Labels:

area-Host
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 19, 2022
Closed
vitek-karas
vitek-karas approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

src/native/corehost/hostpolicy/deps_resolver.cpp Outdated Show resolved Hide resolved
@elinor-fung elinor-fung merged commit e0aff76 into dotnet:main Nov 22, 2022
@elinor-fung elinor-fung deleted the cleanup-deps-resolver branch November 22, 2022 19:13
@build-analysis build-analysis bot mentioned this pull request Nov 22, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @vitek-karas