Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly test is failing in CI #78718

Closed
ViktorHofer opened this issue Nov 22, 2022 · 4 comments · Fixed by #78739
Closed

FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly test is failing in CI #78718

ViktorHofer opened this issue Nov 22, 2022 · 4 comments · Fixed by #78739
Assignees
@MihaZupan
Labels
arch-arm64 area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' bug Known Build Error Use this to report build issues in the .NET Helix tab
Milestone
8.0.0

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 22, 2022 •
edited by build-analysis bot
Loading

https://dev.azure.com/dnceng-public/public/_build/results?buildId=91029&view=ms.vss-test-web.build-test-results-tab&runId=1918218&resultId=189964&paneView=debug

Configuration: net7.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.314.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.14-helix-arm64v8 & net7.0-Linux-Debug-arm64-CoreCLR_checked-(Ubuntu.1804.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8

Assert.Equal() Failure
↓ (pos 4)
Expected: FileÃName.bat
Actual:   File?�Name.bat
↑ (pos 4)
   at System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly() in /_/src/libraries/System.Net.Http/tests/UnitTests/Headers/ContentDispositionHeaderValueTest.cs:line 211
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59

{
  "ErrorMessage": "Expected: FileÃName.bat",
  "BuildRetry": false
}

cc @dotnet/ncl

Report

Build Definition Test Pull Request
91636 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78736
91625 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78741
91517 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78738
91507 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78736
91483 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78580
91457 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78733
91365 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly
91336 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78728
91307 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly
91215 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78572
91201 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78709
91155 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78720
90632 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78685
91127 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78714
91029 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78703
90647 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #77996
91022 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78580
91010 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78700
90970 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78702
90927 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78698
90857 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78557
90830 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78020
90801 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78678
90662 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly
90652 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78688
90641 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly
90620 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly
90558 dotnet/runtime System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly #78680

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
28 28 28
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 22, 2022
@ghost
Copy link

ghost commented Nov 22, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

https://dev.azure.com/dnceng-public/public/_build/results?buildId=91029&view=ms.vss-test-web.build-test-results-tab&runId=1918218&resultId=189964&paneView=debug

Configuration: net7.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.314.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.14-helix-arm64v8 & net7.0-Linux-Debug-arm64-CoreCLR_checked-(Ubuntu.1804.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8

Assert.Equal() Failure
↓ (pos 4)
Expected: FileÃName.bat
Actual:   File?�Name.bat
↑ (pos 4)
   at System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly() in /_/src/libraries/System.Net.Http/tests/UnitTests/Headers/ContentDispositionHeaderValueTest.cs:line 211
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59

cc @dotnet/ncl

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net.Http, untriaged
Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Nov 22, 2022

It's being investigated in #78709

@MihaZupan
Copy link
Member

For reference: #78660 (comment)

#78660 changed how we do encoding here and now we're seeing failures on checked arm64 builds.

@MihaZupan MihaZupan mentioned this issue Nov 22, 2022
Merged
@AaronRobinsonMSFT AaronRobinsonMSFT added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Nov 22, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Nov 22, 2022
Merged
@runfoapp runfoapp bot mentioned this issue Nov 22, 2022
Closed
@ViktorHofer ViktorHofer mentioned this issue Nov 22, 2022
Merged
@MihaZupan MihaZupan self-assigned this Nov 22, 2022
@MihaZupan MihaZupan added the bug label Nov 22, 2022
@MihaZupan MihaZupan added this to the 8.0.0 milestone Nov 22, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 22, 2022
@MihaZupan MihaZupan mentioned this issue Nov 23, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 23, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MihaZupan MihaZupan

Labels
arch-arm64 area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' bug Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Improve IndexOfAnyAsciiSearcher ARM throughput MihaZupan/runtime
5 participants
@EgorBo @jeffhandley @ViktorHofer @MihaZupan @AaronRobinsonMSFT