Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix Equals in hot reload scenario #78258

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2022

Backport of #78249 to release/7.0

/cc @buyaa-n

Description

While fixing Hot Reload breaks MethodInfo equality we caused regression in .NET 7 Huge Breaking Issue in Net7 with MemberInfo equality

Customer Impact

The regression causes wrong equality check result for derived members of a Type when hot reload enabled. As hot reload is enabled by default in VS it could cause failures for any customer that uses Reflection and debugging their code. They would need to disable hot reload to be able to debug further

Testing

Added unit tests that reproes the issue

Risk

Low, the fix adds one additional check (of ReflectedTypes) but only affects hot reload scenarios

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Nov 12, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78249 to release/7.0

/cc @buyaa-n

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@buyaa-n buyaa-n added the Servicing-consider Issue for next servicing release review label Nov 12, 2022
@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 14, 2022

Approved for servicing by email, updating the label with approved

The failure unrelated and related issue is linked

@buyaa-n buyaa-n added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 14, 2022
@carlossanlop
Copy link
Member

CI failure is known and unrelated: #77988
Approved by Tactics. Signed-off by area owners.
No OOB package authoring changes for System.Private.CoreLib changes.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 5397399 into release/7.0 Nov 14, 2022
@carlossanlop carlossanlop deleted the backport/pr-78249-to-release/7.0 branch November 14, 2022 19:42
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants